Skip to content

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Oct 1, 2025

Issue #, if available:

Description of changes:
Adds explicit dependency on 'set-dependency-versions' in 'sourcesJar'


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner October 1, 2025 02:10
@trivikr trivikr merged commit 2cf4c60 into main Oct 1, 2025
13 checks passed
@trivikr trivikr deleted the clean-publish-to-maven-local branch October 1, 2025 02:26
@trivikr
Copy link
Contributor Author

trivikr commented Oct 6, 2025

Revisiting from release failure in internal JS-6275

This dependency was added when build and publish smithy-ts step had failed in aws-sdk-js-v3

A problem was found with the configuration of task ':smithy-typescript-codegen:sourcesJar' (type 'Jar').
  - Gradle detected a problem with the following location: '/tmp/smithy-typescript-1d003498c9c145ba44fa8c51b25eec629f65a940/smithy-typescript-codegen/build/generated/resources'.
    
    Reason: Task ':smithy-typescript-codegen:sourcesJar' uses this output of task ':smithy-typescript-codegen:set-dependency-versions' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':smithy-typescript-codegen:set-dependency-versions' as an input of ':smithy-typescript-codegen:sourcesJar'.
      2. Declare an explicit dependency on ':smithy-typescript-codegen:set-dependency-versions' from ':smithy-typescript-codegen:sourcesJar' using Task#dependsOn.
      3. Declare an explicit dependency on ':smithy-typescript-codegen:set-dependency-versions' from ':smithy-typescript-codegen:sourcesJar' using Task#mustRunAfter.
    
    For more information, please refer to https://docs.gradle.org/9.0.0/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

Logs: https://github.com/aws/aws-sdk-js-v3/actions/runs/18148721923/job/51655310765?pr=7396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants