fix(util-body-length-node): restrict fs calls to fs.ReadStream objects #1735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#7408
Description of changes:
In the Node.js body length calculator, only call lstat and fstat if the input body is an actual instance of fs.ReadStream, and not merely possessing a
.path
or.fd
property.This would break an edge case where a user was expecting a body length calculation on a duck-typed FileReadStream that didn't extend the fs.ReadStream prototype, but that should be rarer than an accidental usage of the
path
property.In such cases, the content length should be given by the caller in e.g. the
ContentLength
property, if available on the operation in question, or changed to extend the ReadStream prototype.