Skip to content

Pass logger and filters to HandlerExecutionContext #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2020
Merged

Pass logger and filters to HandlerExecutionContext #207

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5d2be6
Add inputFilterLog and outputFilterLog to HandlerExecutionContext
trivikr Aug 27, 2020
94b1417
Use output variable name for outputFilterLog
trivikr Aug 27, 2020
3605c1a
Use OptionalUtils instead of if-else
trivikr Aug 28, 2020
35eaeb4
Pass logger from configuration
trivikr Aug 28, 2020
0ce1c46
Explicitly defined input/output as any
trivikr Aug 28, 2020
7822da0
Rename filterLog -> filterSensitiveLog
trivikr Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import software.amazon.smithy.model.traits.StreamingTrait;
import software.amazon.smithy.typescript.codegen.integration.ProtocolGenerator;
import software.amazon.smithy.typescript.codegen.integration.RuntimeClientPlugin;
import software.amazon.smithy.utils.OptionalUtils;

/**
* Generates a client command using plugins.
Expand Down Expand Up @@ -151,8 +152,19 @@ private void generateCommandMiddlewareResolver(String configType) {

// Resolve the middleware stack.
writer.write("\nconst stack = clientStack.concat(this.middlewareStack);\n");
writer.write("const { logger } = configuration;");
writer.openBlock("const handlerExecutionContext: HandlerExecutionContext = {", "}", () -> {
writer.write("logger: {} as any,");
writer.write("logger,");
writer.openBlock("inputFilterSensitiveLog: ", ",", () -> {
OptionalUtils.ifPresentOrElse(operationIndex.getInput(operation),
input -> writer.writeInline("$T.filterSensitiveLog", symbolProvider.toSymbol(input)),
() -> writer.writeInline("(input: any) => input"));
});
writer.openBlock("outputFilterSensitiveLog: ", ",", () -> {
OptionalUtils.ifPresentOrElse(operationIndex.getOutput(operation),
output -> writer.writeInline("$T.filterSensitiveLog", symbolProvider.toSymbol(output)),
() -> writer.writeInline("(output: any) => output"));
});
});
writer.write("const { requestHandler } = configuration;");
writer.openBlock("return stack.resolve(", ");", () -> {
Expand Down