Load other shapes when a mixin can't be resolved #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this when working on the language server - if you have a model like: ``` $version: "2" namespace com.foo string Foo @mixin structure Bar {} structure Baz with [Unknown] {} ``` loading it will result in `Foo` and `Bar` also not being loaded. It seems like the reason for this was that if TopologicalShapeSort failed, we wouldn't build _any_ shapes into the model, despite TopologicalShapeSort being able to resolve some shapes. Practically speaking I'm not sure if this means much in general, but for the language server its big because without it, you can't have mixin completions unless you either don't reload the model on changes (which means you can't type a mixin, then get completions to use it), or don't update the server's version of the model if the new version is broken (which reduces the quality of diagnostics, and has the same issue as the other way).
haydenbaker
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this when working on the language server - if you have a model like:
loading it will result in
FooandBaralso not being loaded. It seems like the reason for this was that if TopologicalShapeSort failed, we wouldn't build any shapes into the model, despite TopologicalShapeSort being able to resolve some shapes.Practically speaking I'm not sure if this means much in general, but for the language server its big because without it, you can't have mixin completions unless you either don't reload the model on changes (which means you can't type a mixin, then get completions to use it), or don't update the server's version of the model if the new version is broken (which reduces the quality of diagnostics, and has the same issue as the other way).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.