Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for fullscreen toggle + keyboard shortcut #68

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Conversation

seanoliver
Copy link
Collaborator

I noticed that I'm spending a lot of time dragging to resize the menubar to make it fullscreen. With this small update, you can hit Cmd + Shift + F (which is conveniently right next to Cmd + Shift + G!) to toggle back and forth between full viewport width and the default 1200 pixel width.

Great for people on ultra-wide monitors, you can probably now easily fit 6 or 7 providers side-by-side.

This demo video shows it on my laptop screen but I can take another one on my super-wide monitor when I get a chance if we think it's worth sharing!

fullscreen.toggle.mp4

@seanoliver seanoliver requested a review from swyxio July 15, 2023 21:23
Copy link
Contributor

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, but please update readme when you add new functionality! make it a habit. no doing without telling.

@seanoliver
Copy link
Collaborator Author

Ah thanks! Updated the README and will make it a habit.

@swyxio swyxio merged commit a11d43e into main Jul 16, 2023
@Eggwise
Copy link

Eggwise commented Jul 31, 2023

@seanoliver How can i disable this?

Now i cant use CMD SHIFT F5 in my other applications while Smol is on...
I use it to find in files in my IDEA. So this is very annoying

@lgandecki
Copy link
Contributor

I think this is probably an overkill, there is a ton of apps that help resize windows on MacOS. If someone doesn't use them, but feels the need to full screen this one.. most probably that person would find it helpful to full screen other apps as well, using a universal tool.
I currently use https://www.raycast.com/ for that, but it does a lot of other things as well. I used to use totalspaces (but with raycast it didn't make sense to have two apps do the same thing). Sizeup is small and great for it as well.

Adding a lot of keyboard shortcuts here especially since they are difficult to modify is probably not the way to go. I don't think I've ever seen an app implement a full-screen toggle like that manually, not sure if this is THE ONE that needs it :)

just my opinion of course, feel free to ignore it - but the fact of clashing shortcuts is definitely problematic, especially since we can achieve the same thing in more standard way.

@seanoliver
Copy link
Collaborator Author

seanoliver commented Aug 2, 2023

Hey @lgandecki @Eggwise, thank you for your well-reasoned feedback here. I see now how the fullscreen keyboard shortcut can be a problem and we've removed it in #104.

I also wanted to address the previous comment I'd posted here. After hearing from @swyxio, I realized that my attempt at a bit of sarcasm didn't come off as intended. I apologize if it seemed like I was dismissing your feedback. That was not my intention at all and I appreciate you bringing this to my attention.

I'm grateful for this kind of feedback because it helps me build a broader understanding of users perspectives. So please keep it coming — you're helping me grow as a developer and I appreciate it.

@swyxio swyxio deleted the full-screen branch August 3, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants