-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for fullscreen toggle + keyboard shortcut #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, but please update readme when you add new functionality! make it a habit. no doing without telling.
Ah thanks! Updated the README and will make it a habit. |
@seanoliver How can i disable this? Now i cant use CMD SHIFT F5 in my other applications while Smol is on... |
I think this is probably an overkill, there is a ton of apps that help resize windows on MacOS. If someone doesn't use them, but feels the need to full screen this one.. most probably that person would find it helpful to full screen other apps as well, using a universal tool. Adding a lot of keyboard shortcuts here especially since they are difficult to modify is probably not the way to go. I don't think I've ever seen an app implement a full-screen toggle like that manually, not sure if this is THE ONE that needs it :) just my opinion of course, feel free to ignore it - but the fact of clashing shortcuts is definitely problematic, especially since we can achieve the same thing in more standard way. |
Hey @lgandecki @Eggwise, thank you for your well-reasoned feedback here. I see now how the fullscreen keyboard shortcut can be a problem and we've removed it in #104. I also wanted to address the previous comment I'd posted here. After hearing from @swyxio, I realized that my attempt at a bit of sarcasm didn't come off as intended. I apologize if it seemed like I was dismissing your feedback. That was not my intention at all and I appreciate you bringing this to my attention. I'm grateful for this kind of feedback because it helps me build a broader understanding of users perspectives. So please keep it coming — you're helping me grow as a developer and I appreciate it. |
I noticed that I'm spending a lot of time dragging to resize the menubar to make it fullscreen. With this small update, you can hit
Cmd
+Shift
+F
(which is conveniently right next toCmd
+Shift
+G
!) to toggle back and forth between full viewport width and the default 1200 pixel width.Great for people on ultra-wide monitors, you can probably now easily fit 6 or 7 providers side-by-side.
This demo video shows it on my laptop screen but I can take another one on my super-wide monitor when I get a chance if we think it's worth sharing!
fullscreen.toggle.mp4