Skip to content

Commit 10318b0

Browse files
committed
fix: fix module resolving
This issue fixes #59 It is possible to create a configuration which will result into a wrong state but it should not happen in 99.99% cases.
1 parent 624e8f8 commit 10318b0

File tree

13 files changed

+234
-48
lines changed

13 files changed

+234
-48
lines changed

.eslintrc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"jest": true
66
},
77
"rules": {
8+
"no-plusplus": "off",
89
"no-param-reassign": "off",
910
"react/jsx-filename-extension": ["error", { "extensions": [".js"] }],
1011
"react/jsx-wrap-multilines": "off",

example/.babelrc

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
11
{
2-
"presets": ["react", ["env", {
3-
"targets": {
4-
"node": "current"
5-
}
6-
}]],
2+
"presets": [
3+
"react",
4+
[
5+
"env",
6+
{
7+
"targets": {
8+
"node": "current"
9+
}
10+
}
11+
]
12+
],
713
"plugins": [
814
"dynamic-import-node",
915
"loadable-components/babel",

example/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
public/*.js
1+
public

example/A/Component.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export default () => 'A'

example/A/index.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import React, { Component } from 'react'
2+
import loadable from 'loadable-components'
3+
4+
const Loaded = loadable(() => import('./Component'))
5+
6+
export default Loaded

example/App.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import React from 'react'
22
import loadable from 'loadable-components'
33
import { hot } from 'react-hot-loader'
4+
import A from './A'
5+
import B from './B'
46

57
const AsyncWhat = loadable(() =>
68
import(/* webpackChunkName: "What" */ './What.js'),
@@ -12,6 +14,8 @@ const AsyncBig = loadable(() =>
1214

1315
const App = () => (
1416
<div>
17+
<A />
18+
<B />
1519
Hello <AsyncWhat />!
1620
</div>
1721
)

example/B/Component.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export default () => 'B'

example/B/index.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import React, { Component } from 'react'
2+
import loadable from 'loadable-components'
3+
4+
const Loaded = loadable(() => import('./Component'))
5+
6+
export default Loaded

example/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
},
1010
"dependencies": {
1111
"express": "^4.16.3",
12-
"loadable-components": "/Users/neoziro/projects/loadable-components/loadable-components-v1.4.1-alpha.2.tgz",
12+
"loadable-components": "latest",
1313
"react": "^16.3.2",
1414
"react-dom": "^16.3.2",
15-
"react-hot-loader": "^4.1.2"
15+
"react-hot-loader": "^4.1.3"
1616
},
1717
"devDependencies": {
1818
"babel-cli": "^6.26.0",
@@ -21,11 +21,11 @@
2121
"babel-plugin-syntax-dynamic-import": "^6.18.0",
2222
"babel-plugin-transform-class-properties": "^6.24.1",
2323
"babel-plugin-transform-object-rest-spread": "^6.26.0",
24-
"babel-preset-env": "^1.6.1",
24+
"babel-preset-env": "^1.7.0",
2525
"babel-preset-react": "^6.24.1",
26-
"nodemon": "^1.17.3",
27-
"webpack": "^4.7.0",
28-
"webpack-cli": "^2.1.2",
26+
"nodemon": "^1.17.4",
27+
"webpack": "^4.8.2",
28+
"webpack-cli": "^2.1.3",
2929
"webpack-dev-server": "^3.1.4"
3030
}
3131
}

example/server.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import path from 'path'
12
import React from 'react'
23
import ReactDOMServer from 'react-dom/server'
34
import express from 'express'

0 commit comments

Comments
 (0)