Move DNSBL check after MAIL FROM to make AUTH available #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The best practice for using DNSBLs is to run them only on port 25 and push all your MSA traffic to port 587 where you do not have DNSBLs and instead require STARTTLS + AUTH. For that use case, running the DNSBL checks early (during connect) is by far the preferred option. If you modified this PR to instead add a config option that let one specify which hook this plugin is registered on |
|
You are right, it seems better solution to run different config for submission port. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If plugin is set to disconnect before login is available then all IP addresses with DNSBL record will not be able to send email even if they are proper users (traveling, shared ISPs IPs...)