Skip to content

Updated single linked list python operations #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

kumarankm
Copy link
Contributor

Have you read the Contributing Guidelines on Pull Requests?

Yes

Description

Updated the python code of singly linked list, where removing is done by using value instead of index

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests

#601 [Updating singly linked list with python]

Fill up the DCP form

If you are a part of DCP 21, fill up this form after the PR is merged.

The links provided in the form will be checked thoroughly, if someone tries fooling around, strict actions will be taken against the individual.

@smv1999 smv1999 linked an issue Jul 17, 2021 that may be closed by this pull request
@smv1999 smv1999 requested review from noviicee and Saviour1001 July 17, 2021 14:31
@noviicee noviicee added DCP21 Python Contributing in Python labels Jul 17, 2021
Copy link
Contributor

@noviicee noviicee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumarankm please take input from the user.

@kumarankm
Copy link
Contributor Author

@kumarankm please take input from the user.

Yeah sure, but for all those previous operations they didn't take input dynamically @noviicee

@github-actions github-actions bot removed the Python Contributing in Python label Jul 17, 2021
@kumarankm
Copy link
Contributor Author

@noviicee Done 👍🏻

Copy link
Contributor

@noviicee noviicee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a case in the removal method when the value passed for removal is not present in the Linked List.

@kumarankm
Copy link
Contributor Author

Add a case in the removal method when the value passed for removal is not present in the Linked List.

@noviicee Added 👍🏻

@noviicee
Copy link
Contributor

noviicee commented Jul 21, 2021

@kumarankm please take dynamic input from the user to insert values and form a linked list. Rest the methods look fine so far.

@kumarankm
Copy link
Contributor Author

@kumarankm please take dynamic input from the user to insert values and form a linked list. Rest the methods look fine so far.

@noviicee Changed 👍🏻 Got a dynamic input for every single operation 🤓

@noviicee noviicee requested review from smv1999 and Saviour1001 and removed request for Saviour1001 July 21, 2021 14:38
@smv1999 smv1999 merged commit c5d6b37 into smv1999:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating singly linked list with python
3 participants