Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious additional space added between adjacent replacement fields #222

Closed
edbennett opened this issue Apr 1, 2024 · 2 comments · Fixed by #223
Closed

Spurious additional space added between adjacent replacement fields #222

edbennett opened this issue Apr 1, 2024 · 2 comments · Fixed by #223
Labels
bug Something isn't working

Comments

@edbennett
Copy link

edbennett commented Apr 1, 2024

This is almost certainly closely related to #220, but when an f-string contains two adjacent replacement fields (e.g. f"{var1}{var2}") then snakefmt will insert a space between them (i.e. f"{var1} {var2}").

Since in general filenames are sensitive to having extra characters inserted, this means that a working rule is broken by this change.

This occurs with Python 3.12 but not Python 3.11.

@mbhall88 mbhall88 added the bug Something isn't working label Apr 2, 2024
@mbhall88
Copy link
Member

mbhall88 commented Apr 2, 2024

Urgh that is quite nasty. I'll try and get to around to this ASAP

@edbennett
Copy link
Author

Thanks! To confirm, #223 correctly fixes the errant behaviour in the case that was causing me issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants