docs: update pre commit example #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional comment: Also this link in the changelog is does not do what it is expected to because there is no |
mbhall88
changed the title
|
Thanks for this @jpwgnr and for the heads up about the changelog. |
mbhall88
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I realised that from your release
0.5.0to0.6.0the labels switched from0.5.0tov0.6.0.Therefore, the example pre-commit snippet in the README is still correct, but once somebody wants to go beyond by just updating the number (as I did) they will get an error from pre-commit.
I think it would be nice to update this small section. Here is a suggestion for the fix with the newest
snakefmtversion.