fix: Detect pandas availability to select serializer #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previous try catch solution wasn't triggered
DrYak
changed the title
johanneskoester
approved these changes
Jun 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
for a potential test, see this Discord post but I would need the help of someone more fulent into the CI/CD infrastructure of snakemake to guide me. |
johanneskoester
pushed a commit
that referenced
this pull request
Jun 16, 2023
🤖 I have created a release *beep* *boop* --- ## [7.28.3](v7.28.2...v7.28.3) (2023-06-16) ### Bug Fixes * Detect pandas availability to select serializer ([#2300](#2300)) ([e08a771](e08a771)) ### Performance Improvements * avoid superflous mtime checks when the same file is referred to by multiple jobs ([#2284](#2284)) ([eb6e2e1](eb6e2e1)) ### Documentation * update docs for azbatch and dockerhub ref ([#2298](#2298)) ([908dbf1](908dbf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vsoch
pushed a commit
to vsoch/snakemake
that referenced
this pull request
Jun 20, 2023
### Description - previous try catch solution wasn't triggered - use detecting availability of the module instead ### QC <!-- Make sure that you can tick the boxes below. --> * [ ] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). --------- Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de> Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
vsoch
pushed a commit
to vsoch/snakemake
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [7.28.3](snakemake/snakemake@v7.28.2...v7.28.3) (2023-06-16) ### Bug Fixes * Detect pandas availability to select serializer ([snakemake#2300](snakemake#2300)) ([e08a771](snakemake@e08a771)) ### Performance Improvements * avoid superflous mtime checks when the same file is referred to by multiple jobs ([snakemake#2284](snakemake#2284)) ([eb6e2e1](snakemake@eb6e2e1)) ### Documentation * update docs for azbatch and dockerhub ref ([snakemake#2298](snakemake#2298)) ([908dbf1](snakemake@908dbf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).