Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix None type error when invoking Workflow object manually #1366

Merged
merged 3 commits into from Feb 5, 2022

Conversation

Hoeze
Copy link
Contributor

@Hoeze Hoeze commented Feb 1, 2022

Description

After updating snakemake to its current version, the following code fails with TypeError: 'NoneType' object is not iterable:

workflow = Workflow(snakefile=snakefile)

This PR attempts to fix that issue.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@Hoeze Hoeze requested a review from johanneskoester as a code owner Feb 1, 2022
@johanneskoester johanneskoester changed the title fix none-type fix: fix None type error when invoking Workflow object manually Feb 5, 2022
@johanneskoester
Copy link
Contributor

johanneskoester commented Feb 5, 2022

Thanks! Can you please format your the code with black?

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hoeze
Copy link
Contributor Author

Hoeze commented Feb 5, 2022

@johanneskoester the formatting error was unrelated and fixed on current master :)
After merging, things should be all fine.

@johanneskoester johanneskoester merged commit fca3895 into snakemake:main Feb 5, 2022
6 checks passed
@Hoeze Hoeze deleted the fix-nonetype branch Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants