Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed bug in needrun computation of jobs downsteam of checkpoints #1704

Merged
merged 2 commits into from
Jun 8, 2022
Merged

fix: fixed bug in needrun computation of jobs downsteam of checkpoints #1704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aaade9
fix: fixed bug in needrun computation of jobs downsteam of checkpoints
johanneskoester Jun 7, 2022
e9512ad
more fine grained removal from DAG._reason
johanneskoester Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions snakemake/dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,6 @@ def update_needrun(job):
# depending jobs of jobs that are needrun as a prior
# can be skipped
continue

if update_needrun(job):
queue.append(job)
masked.update(self.bfs(self.depending, job))
Expand Down Expand Up @@ -1703,10 +1702,11 @@ def delete_job(self, job, recursive=True, add_dependencies=False):
if not depending and recursive:
self.delete_job(job_)
del self.dependencies[job]
if job in self._reason:
del self._reason[job]
if job in self._needrun:
self._len -= 1
self._needrun.remove(job)
del self._reason[job]
if job in self._finished:
self._finished.remove(job)
if job in self._dynamic:
Expand Down