fix: is_run error with local, group jobs #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into a bug where executing a workflow locally causes a crash with group jobs.
```
if self.workflow.verbose or (job.is_run and not job.is_group()):
^^^^^^^^^^
AttributeError: 'GroupJob' object has no attribute 'is_run'
```
Swapping the order of the checks fixes this issue; not sure why the CI didn't catch this bug.
|
Kudos, SonarCloud Quality Gate passed!
|
troycomi
changed the title
johanneskoester
approved these changes
Feb 27, 2023
|
Thanks a lot! |
2 tasks
johanneskoester
pushed a commit
that referenced
this pull request
Mar 1, 2023
🤖 I have created a release *beep* *boop* --- ## [7.24.0](v7.23.1...v7.24.0) (2023-03-01) ### Features * limit the number of input/output files in job properties ([#2149](#2149)) ([d93f091](d93f091)) ### Bug Fixes * [#2130](#2130) by patching the protect() method so the path of files in subdirectories is properly resolved during write-protection ([#2131](#2131)) ([1a754fd](1a754fd)) * `sre_constants` import because of deprecation ([#2139](#2139)) ([3b326db](3b326db)) * ensure user and group rw permissions for metadata files and source cache ([#2132](#2132)) ([cc51faa](cc51faa)) * is_run error with local, group jobs ([#2133](#2133)) ([31bfcd5](31bfcd5)) * require toposort >= 1.10 ([#2145](#2145)) ([3cb54b8](3cb54b8)) ### Documentation * Update modularization.rst ([#2137](#2137)) ([16954c7](16954c7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran into a bug where executing a workflow locally causes a crash with group jobs.
Swapping the order of the checks fixes this issue; not sure why the CI didn't catch this bug.