Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update modularization.rst #2137

Merged
merged 2 commits into from Feb 28, 2023

Conversation

SultanOrazbayev
Copy link
Contributor

Add explicit warning to avoid naming imported module with workflow (keyword). This is based on https://stackoverflow.com/a/75543511/10693596

  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Add explicit warning to avoid naming imported module with `workflow` (keyword). This is based on https://stackoverflow.com/a/75543511/10693596
@SultanOrazbayev SultanOrazbayev changed the title doc: Update modularization.rst docs: Update modularization.rst Feb 23, 2023
Improve precision.
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

Thanks, good idea!

@johanneskoester johanneskoester merged commit 16954c7 into snakemake:main Feb 28, 2023
johanneskoester pushed a commit that referenced this pull request Mar 1, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.24.0](v7.23.1...v7.24.0)
(2023-03-01)


### Features

* limit the number of input/output files in job properties
([#2149](#2149))
([d93f091](d93f091))


### Bug Fixes

* [#2130](#2130) by
patching the protect() method so the path of files in subdirectories is
properly resolved during write-protection
([#2131](#2131))
([1a754fd](1a754fd))
* `sre_constants` import because of deprecation
([#2139](#2139))
([3b326db](3b326db))
* ensure user and group rw permissions for metadata files and source
cache ([#2132](#2132))
([cc51faa](cc51faa))
* is_run error with local, group jobs
([#2133](#2133))
([31bfcd5](31bfcd5))
* require toposort >= 1.10
([#2145](#2145))
([3cb54b8](3cb54b8))


### Documentation

* Update modularization.rst
([#2137](#2137))
([16954c7](16954c7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants