-
Notifications
You must be signed in to change notification settings - Fork 582
feat: offchain validate name owner #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code has been updated to also support offchain subdomains |
dbfb663
to
b55dafc
Compare
dbd43b1
to
6c555fa
Compare
src/utils.ts
Outdated
const sepoliaMissingResolverError = | ||
e.message.includes('UNSUPPORTED_OPERATION') && network === '11155111'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some other way than hardcoding sepolia? this testnet can change time to time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just ignore all unsupported operations irrespective of the network?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else is working well
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
Toward https://github.com/snapshot-labs/workflow/issues/485
This PR adds support for checking a domain owner offchain, using the domain DNS records for top level donain (
https://docs.ens.domains/registry/dns#offchain-verification-gasless), and resolved address for subdomain
For offchain subdomains, it will return the resolved address as owner, since offchain subdomain do not have the concept of owner/controller
Also edit the function signature to always return an address, to be combatible with sx
Test
defi.app
)lucemans.cb.id
Those offchain subdomains should resolved to these addresses