Skip to content

chore: update starknet dependency #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

chore: update starknet dependency #1147

merged 4 commits into from
Apr 24, 2025

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Apr 23, 2025 •
edited
Loading

Fixes snapshot-labs/stamp#371 (comment)

This PR will bump the starknet library to 6.11, to match the one used on sx and stamp.

This will also fix the memory overflow issue, when installed together with the @webinterop/dns-connect, which was resolved via starknet-io/starknet.js@30a4681#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L96

This version bump is causing some side effect, and is requiring some updates in the rollup config, since the rollup-plugin-node-globals package is 7 years old, and don't support optional chaining.

Tests are passing, and manual testing of the UMD build seems fine, can reproduce the issue mentioned in #67

How to test

  • yarn build
  • create an html file with the following content
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Document</title>
  </head>
  <body>
    <script>
      var global = global || window;
    </script>
    <script src="./dist/snapshot.min.js"></script>
    <script>
      snapshot.utils.signMessage(
        window.ethereum,
        'Aasdf',
        '0x556B14CbdA79A36dC33FcD461a04A5BCb5dC2A70'
      );
    </script>
  </body>
</html>```

@wa0x6e wa0x6e marked this pull request as ready for review April 23, 2025 09:15
@wa0x6e wa0x6e requested a review from Copilot April 23, 2025 09:15
Copilot
Copilot AI reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@wa0x6e wa0x6e requested a review from ChaituVR April 24, 2025 08:21
@wa0x6e wa0x6e force-pushed the chore-update-starknet-dependency branch from 916c461 to d22832d Compare April 24, 2025 08:49
ChaituVR
ChaituVR approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 934d82e into master Apr 24, 2025
4 checks passed
@ChaituVR ChaituVR deleted the chore-update-starknet-dependency branch April 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR