feat: allow starknet address in schema and when signing

[wa0x6e]

Toward https://github.com/snapshot-labs/workflow/issues/562

This PR updates the schema and signing logic to accept and sign a payload submitted by starknet address alias

• Allow starknet addresses as member (author, admin, moderator)
• Allow starknet address in the from field of the payload
• Update types for proposal, delete-proposal and vote- to have from field as string instead of address

Test

• Create a proposal or vote payload with a starknet address in the from field.
• Call the proposal or vote function with the corresponding payload
• BEFORE: it return a UNSUPPORTED_OPERATION error
• AFTER: it should sign and submit the message to sequencer

[Copilot]

Pull Request Overview

This pull request updates the schema to support both EVM and Starknet addresses for members, admins, and moderators.

• Updated the "members" property by replacing the single format with an anyOf clause that allows either EVM or Starknet addresses.
• Applied similar changes to the "admins" and "moderators" properties.

[bonustrack]

Are we sure Starknet address doesn't work as address here?

[wa0x6e]

using the address type return the following error:

Error: cannot resolve ENS names without a provider (operation="resolveName", value="", code=UNSUPPORTED_OPERATION, version=wallet/5.8.0)
    at Logger.makeError (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/logger/lib/index.js:238:21)
    at Logger.throwError (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/logger/lib/index.js:247:20)
    at /Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/wallet/lib/index.js:182:40
    at Function.<anonymous> (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/hash/lib/typed-data.js:422:46)
    at step (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/hash/lib/typed-data.js:33:23)
    at Object.next (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/hash/lib/typed-data.js:14:53)
    at /Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/hash/lib/typed-data.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/hash/lib/typed-data.js:4:12)
    at TypedDataEncoder.resolveNames (/Users/wan/Documents/GitHub/snapshot.js-bootstrap/node_modules/@ethersproject/hash/lib/typed-data.js:392:16) {
  reason: 'cannot resolve ENS names without a provider',
  code: 'UNSUPPORTED_OPERATION',
  operation: 'resolveName',
  value: ''
}

[bonustrack]

Is it correct to say you are adding support for from as string but from as address is still available? We should not use string for Ethereum addresses ideally.

[wa0x6e]

Is it correct to say you are adding support for from as string but from as address is still available? We should not use string for Ethereum addresses ideally.

It will be always as string, from the sdk side. We validate the from with a getAddress before signing, so this field will always be a valid address when submitted.

People signing themselves, without the sdk and passing the types manually can continue signing using address

[ChaituVR]

Two new delete-proposal 🤔 i think only one should be added for current change

same for vote vote-string and vote-array, there are two added

[wa0x6e]

removed the duplicate one for proposal, vote- are there twice because of the Vote2 type

[wa0x6e]

In fact no, duplicate proposals type are also legit, due to them being twice in the types.ts (Proposal2)

[ChaituVR]

I think we should remove one, first one can be deprecated i think , but maybe in a different PR

[bonustrack]

utACK

[ChaituVR]

utAck