fix: accept both lowercase and checksum starknet address as valid #1153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR loosen the starknet address validator, to accept both checksum (current) and lowercase (new) addresses as valid. It stil require that addresses are fully padded.,
This will align with the
evmAddress
validation, which is currently accepting both lowercase and checksum.Without this patch, the validator will reject all checksum starknet address. In the ui side, we don't check for case when sending starknet address (like adding member in the space settings), so valid data on the UI will be rejected by sequencer.