feat: allow starknet alias to flag proposal #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for using a starknet alias when flagging proposals. It changes the type definition for the 'from' field in flag proposals from 'address' to 'string' and updates the corresponding hashed types to include the new "flag-proposal" mapping.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/sign/types.ts | Updated the 'from' field type to string for alias compatibility. |
| src/sign/hashedTypes.json | Added mapping for the new "flag-proposal" hashed type. |
Comments suppressed due to low confidence (2)
src/sign/types.ts:179
- Changing the 'from' field from type 'address' to 'string' enables alias support. Please ensure all consuming functions and validations correctly handle the less strict string type.
{ name: 'from', type: 'string' },
src/sign/hashedTypes.json:78
- [nitpick] Add a brief comment in the JSON explaining that the 'flag-proposal' entry is used to support flagging proposals with a starknet alias, similar to the vote mappings.
"6107486ff2c58778b92eac3f9c92b26ab59f30959a12307ae868c197f382cdf6": "flag-proposal"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows starknet alias to flag a proposal.
This is used when a starknet address is added in the space members as admin or moderator