feat: support starknet multisig signature #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors StarkNet signature verification to support multisig signatures by replacing manual contract interaction with the provider's native verification function. It simplifies the verification process and extends support to all StarkNet signature formats including Argent X multisig wallets.
- Replaced manual contract ABI calls with provider's built-in
verifyMessageInStarknetmethod - Removed custom signature array processing logic that was previously needed for different wallet formats
- Added comprehensive test fixtures for various signature types including Argent X multisig
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/verify/starknet.ts | Refactored verification logic to use provider's native method, removed ABI and signature processing |
| src/verify/starknet.spec.ts | Updated test cases to cover new signature formats and changed error handling expectations |
| test/fixtures/starknet/message-alias-argent-x-standard.json | Added test fixture for Argent X standard account signatures |
| test/fixtures/starknet/message-alias-argent-x-multisig.json | Added test fixture for Argent X multisig account signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ChaituVR
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #1182
Continuing on the previous PR, which was adding support for signature with a Guardian,
this PR will add support for signature from argent X multisig wallets.
This PR is refactoring the way we verify a message, by using the provider native function, instead of calling the contract method, which will simplify the process of formatting the signature array before usage.
The code should now be able to verify all starknet signature format