Skip to content

Conversation

mktcode
Copy link
Contributor

@mktcode mktcode commented Nov 8, 2021

Fixed #401

Adds support for different ens resolver addresses per network. Defaults to main net.

The frontend can then be updated like this:

const uri = await getSpaceUri(
  props.spaceId,
  import.meta.env.VITE_DEFAULT_NETWORK
);

This would allow to use ENS names registered e.g on rinkeby for testing.

@bonustrack
Copy link
Member

How this will be used? For testing right with local snapshot and hub?

@mktcode
Copy link
Contributor Author

mktcode commented Nov 8, 2021

@bonustrack Exactly. I still don't have a main net ENS domain.

This update would not break anything as far as I can tell. I could adjust the frontend later.

@ChaituVR
Copy link
Member

ChaituVR commented Nov 9, 2021

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rinkeby ENS resolver
3 participants