Tokio-Tungstenite Async Changes #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes required for tokio-tungstenite async implementation.
dbcfd
force-pushed
the
expose-machine
branch
from
e9dff3c
to
614a506
Compare
|
As far as I can tell yes, since AsyncReadExt and AsyncWriteExt require unpin. Also required for the compat wrapping https://github.com/snapview/tokio-tungstenite/pull/68/files#diff-eeffc045326f81d4c46c22f225d3df90R61. Would gladly welcome alternate solutions for some of this. |
|
The unpin changes may not be needed. There might be another issue causing Unpin to not be handled properly. Trying to dig into it more. |
|
@application-developer-DA was able to remove the unpin with some changes. Still need to expose machine though. |
daniel-abramov
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required for snapview/tokio-tungstenite#68 which upgrades tokio-tungstenite for async/await.