-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the app bind in the auth mechanism (should fix #13335) #13732
Conversation
Google Oauth Recap
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # public/css/dist/skins/skin-red-dark.css # public/css/dist/skins/skin-red-dark.min.css # public/mix-manifest.json
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # public/css/build/app.css # public/css/build/overrides.css # public/css/dist/all.css # public/mix-manifest.json
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # public/css/build/app.css # public/css/build/overrides.css # public/css/dist/all.css # public/mix-manifest.json
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # config/version.php # public/css/dist/all.css # public/js/build/app.js # public/js/build/vendor.js # public/js/dist/all.js # public/mix-manifest.json
This should provide LDAPS support out of the box, and fix #13129
Fixed #13129: Add missing LDAP lib required for LDAPS support
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # config/version.php
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # public/css/dist/skins/skin-yellow-dark.css # public/css/dist/skins/skin-yellow-dark.min.css # public/mix-manifest.json
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # config/version.php
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # public/css/dist/all.css # public/css/dist/bootstrap-table.css # public/js/dist/bootstrap-table.js # public/mix-manifest.json
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # config/version.php
Log non-compliant barcode error as debug message
Signed-off-by: snipe <snipe@snipe.net> # Conflicts: # config/version.php # public/css/build/app.css # public/css/build/overrides.css # public/css/dist/all.css # public/mix-manifest.json
Signed-off-by: Vincent ABEL-GRIMALT <vincent.abel.grimalt@gmail.com>
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
Hi there - thanks for this! Can you please re-target this PR to point to the You don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion. Thanks! |
Thanks, Of course, I do it right away |
Hm, looks like this might need a rebase? I don't think you actually touched 45 files, and some of those commits aren't from you. Can you rebase that for me? |
i preferred to do it the safe way so that one is closed, and i migrated in a new clean PR #13739 |
Description
rebind on app cn to fetch user attributes. so users don't need to have a search / read right only for snipeit.
It's mostly a way to share the "fix"
Fixes #13335
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: