Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13335: Use the app bind in the ldap auth #13739

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vincent-abel
Copy link

@vincent-abel vincent-abel commented Oct 11, 2023

Description

rebind on app cn to fetch user attributes. so users don't need to have a search / read right only for snipeit.
It's mostly a way to share the "fix"

Fixes #13335

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test logins

Test Configuration:

  • Docker with snipeit 6.1.2

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Oct 11, 2023

PR Summary

  • Modification to Logic for User-LDAP Directory Binding
    The team has enhanced the way our software binds users to an LDAP directory. Previously, there may have been instances where a user was not always properly connected to the appropriate LDAP directory. This update ensures a user is correctly assigned by adding a 'rebind' mode. This acts as a double-check procedure, ensuring our app aligns with the user accounts as expected, enhancing the overall user experience.

@snipe snipe requested a review from uberbrady October 11, 2023 16:44
@snipe
Copy link
Owner

snipe commented Oct 24, 2023

@uberbrady Can you take a look at this when you get a moment please?

@vincent-abel
Copy link
Author

Hi, any news?
Is there something blocking?

@vincent-abel
Copy link
Author

@uberbrady @snipe is there something blocking?

@snipe
Copy link
Owner

snipe commented May 29, 2024

@uberbrady ping - can you review for v7 please? We can resolve the conflicts on our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants