-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for JS vimeo plugin #513
Conversation
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6f910b0
to
1dfc25e
Compare
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...script-trackers/browser-tracker/browser-tracker-v3-reference/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,186 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really worries me that we have so much duplication. In any case, all comments above apply here as well. It would be great if you could make a single reusable page and import it into both of these pages. Reusable pages can have parameters. Feel free to slack me if you need help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note, we plan to merge the two sets of pages for the browser and tag tracker into one while adding a tabbed interface on snippets to switch between them so it might be better to publish this as is to make it easier to merge then (I think @mscwilson is planned to work on this). Reusable fragments would work too (and that's what we use in the media plugin docs), just might be unnecessary given the planned work.
9ea3e52
to
1f7422d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -0,0 +1,186 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note, we plan to merge the two sets of pages for the browser and tag tracker into one while adding a tabbed interface on snippets to switch between them so it might be better to publish this as is to make it easier to merge then (I think @mscwilson is planned to work on this). Reusable fragments would work too (and that's what we use in the media plugin docs), just might be unnecessary given the planned work.
...javascript-trackers/javascript-tracker/javascript-tracker-v3/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...javascript-trackers/javascript-tracker/javascript-tracker-v3/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...javascript-trackers/javascript-tracker/javascript-tracker-v3/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
...javascript-trackers/javascript-tracker/javascript-tracker-v3/plugins/vimeo-tracking/index.md
Outdated
Show resolved
Hide resolved
d3fe201
to
4c2adb6
Compare
This PR adds docs for the Vimeo tracking plugin.