Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for JS vimeo plugin #513

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Add docs for JS vimeo plugin #513

merged 1 commit into from
Aug 10, 2023

Conversation

greg-el
Copy link
Contributor

@greg-el greg-el commented Jun 30, 2023

This PR adds docs for the Vimeo tracking plugin.

@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 4c2adb6
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/64d4f09c37f2c500089aa09b
😎 Deploy Preview https://deploy-preview-513--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@greg-el greg-el force-pushed the add-vimeo-plugin-docs branch 2 times, most recently from 6f910b0 to 1dfc25e Compare July 5, 2023 11:31
@greg-el greg-el marked this pull request as ready for review July 5, 2023 13:29
@@ -0,0 +1,186 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really worries me that we have so much duplication. In any case, all comments above apply here as well. It would be great if you could make a single reusable page and import it into both of these pages. Reusable pages can have parameters. Feel free to slack me if you need help

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note, we plan to merge the two sets of pages for the browser and tag tracker into one while adding a tabbed interface on snippets to switch between them so it might be better to publish this as is to make it easier to merge then (I think @mscwilson is planned to work on this). Reusable fragments would work too (and that's what we use in the media plugin docs), just might be unnecessary given the planned work.

@greg-el greg-el force-pushed the add-vimeo-plugin-docs branch 2 times, most recently from 9ea3e52 to 1f7422d Compare August 4, 2023 14:13
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,186 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note, we plan to merge the two sets of pages for the browser and tag tracker into one while adding a tabbed interface on snippets to switch between them so it might be better to publish this as is to make it easier to merge then (I think @mscwilson is planned to work on this). Reusable fragments would work too (and that's what we use in the media plugin docs), just might be unnecessary given the planned work.

@greg-el greg-el requested a review from stanch August 4, 2023 15:32
@greg-el greg-el merged commit 12a941c into main Aug 10, 2023
4 checks passed
@greg-el greg-el deleted the add-vimeo-plugin-docs branch August 10, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants