Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for new GCP deployment #586

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Tweaks for new GCP deployment #586

merged 2 commits into from
Oct 17, 2023

Conversation

jbeemster
Copy link
Member

@jbeemster jbeemster commented Aug 21, 2023

snowplow/quickstart-examples#68

@stanch this pulls all GCP modules up to date with how we deploy Azure + LICENSE changes across all of them. These PRs need to be merged concurrently.

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit c9fdc2e
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/64e3c3cdbdd4970008d588a6
😎 Deploy Preview https://deploy-preview-586--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbeemster jbeemster requested a review from stanch August 21, 2023 05:16
Copy link
Collaborator

@stanch stanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double-check this page? https://docs.snowplow.io/docs/first-steps/querying/?offering=opensource

A couple of things I noticed:

  • The page mentions postgres_db_address, but here you have postgres_db_ip_address. Are they meant to be different on AWS and GCP (e.g. because the AWS one is a domain name?) If so we should mention both.
  • The BigQuery database used to be <prefix>_snowplow_db and is now <prefix>_pipeline_db. I kinda prefer the old name... But in any case needs changing either here or in Terraform. It is also mentioned on this page.

@jbeemster
Copy link
Member Author

jbeemster commented Aug 21, 2023

The page mentions postgres_db_address, but here you have postgres_db_ip_address. Are they meant to be different on AWS and GCP (e.g. because the AWS one is a domain name?) If so we should mention both.

Indeed on GCP its an IP address instead of a domain name. Both should be mentioned yes!


EDIT: Have now made it postgres_db_address everywhere instead to simplify things.

The BigQuery database used to be _snowplow_db and is now _pipeline_db. I kinda prefer the old name... But in any case needs changing either here or in Terraform. It is also mentioned on this page.

In fact it was already pipeline_db in the default pipeline deployment (secure had snowplow_db so normalized it). Happy to revert back to snowplow_db though.


EDIT: Have now reverted back to _snowplow_db everywhere for BigQuery dataset.

@stanch stanch merged commit 22009d4 into main Oct 17, 2023
4 checks passed
@stanch stanch deleted the gcp-revamp-2023 branch October 17, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants