Common: add tests for required property that is explicitly set to nul… #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjben
reviewed
Jun 23, 2022
| @@ -0,0 +1,32 @@ | |||
| package com.snowplowanalytics.snowplow.enrich.common.enrichments | |||
Comment on lines
3
to
22
| import cats.syntax.option._ | ||
| import com.snowplowanalytics.snowplow.enrich.common.adapters.RawEvent | ||
| import com.snowplowanalytics.snowplow.enrich.common.loaders.CollectorPayload | ||
| import com.snowplowanalytics.snowplow.enrich.common.outputs.EnrichedEvent | ||
| import com.snowplowanalytics.snowplow.enrich.common.SpecHelpers.MapOps | ||
| import org.specs2.mutable.Specification |
There was a problem hiding this comment.
Usually we separate packages that come from different artifacts with newlines, and we finish by Snowplow ones
Comment on lines
17
to
26
|
|
||
| import com.snowplowanalytics.iglu.core.{SchemaKey, SchemaVer, SelfDescribingData} | ||
| import com.snowplowanalytics.iglu.client.ClientError.{ResolutionError, ValidationError} | ||
|
|
||
| import com.snowplowanalytics.snowplow.badrows._ | ||
|
|
||
| import io.circe.Json | ||
|
|
||
| import io.circe.parser._ | ||
| import cats.data.NonEmptyList | ||
|
|
There was a problem hiding this comment.
Same, new lines should stay
dilyand
force-pushed
the
test/required-explicit-null-2
branch
from
56acddd
to
c9e3748
Compare
dilyand
force-pushed
the
test/required-explicit-null-2
branch
from
c9e3748
to
565bc36
Compare
|
Addressed comments and rebased on latest |
spenes
force-pushed
the
develop
branch
3 times, most recently
from
0ac9762
to
6144b5a
Compare
spenes
force-pushed
the
develop
branch
2 times, most recently
from
29f2672
to
4c373e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.