Split client into client and transport (preelminary PR for Dark Sky integration) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFradet
reviewed
Jul 12, 2018
| * Create `OwmClient` with specified underlying `Transport` | ||
| * @param transport instance of `Transport` which will do the actual sending of data | ||
| */ | ||
| def basicClient[F[_]: Sync](transport: Transport[F]): OwmClient[F] = |
There was a problem hiding this comment.
I don't think we should expose this one?
| * geoPrecision 1 will give ~60km infelicity if worst case; 2 ~30km etc | ||
| * @param transport instance of `Transport` which will do the actual sending of data | ||
| */ | ||
| def cacheClient[F[_]: Concurrent](cacheSize: Int, geoPrecision: Int, transport: Transport[F]): F[OwmCacheClient[F]] = |
| */ | ||
| case class OwmClient[F[_]: Sync](appId: String, apiHost: String = "api.openweathermap.org", ssl: Boolean = false) | ||
| extends Client[F] { | ||
| class OwmClient[F[_]] private[openweather] (private[openweather] val transport: Transport[F]) { |
There was a problem hiding this comment.
why is transport private[openweather] and not just simply private?
|
@BenFradet done |
BenFradet
approved these changes
Jul 12, 2018
Codecov Report
@@ Coverage Diff @@
## develop #74 +/- ##
===========================================
- Coverage 78.4% 75.59% -2.81%
===========================================
Files 9 11 +2
Lines 125 127 +2
Branches 2 2
===========================================
- Hits 98 96 -2
- Misses 27 31 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to moving and splitting files around, git diff was not too kind to us, hence this PR. Could not make it smaller though.
Most important changes:
providers.openweather.OpenWeatherMapobject, constructors of these clients are package-private. This is also important because of possible changes comming with Split OWM API or make it more explicit about valid URLs #64Transportwas split from theClient. It's similar to transport in 0.3, but contains everything needed for decoding (where transport in 0.3 returned jsons)TimeoutHttpTransport