Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable limit for the maximum age and number of events in the event store and remove old events before sending #660

Closed
matus-tomlein opened this issue Jan 19, 2024 · 0 comments
Labels
status:completed Completed - but might not be released yet.
Milestone

Comments

@matus-tomlein
Copy link
Contributor

matus-tomlein commented Jan 19, 2024

The event store is currently unbounded meaning that if events fail to be sent to the collector, they are never removed from the event store. This can lead to it growing endlessly (if for instance an ad blocker blocks the collector domain) which is likely to have an impact on the app.

We should add configurable limits to the event store so that old events are removed. We could have two such limits:

  • maximum event store size – in case the number of events surpasses this threshold, oldest events will be removed until we are under the threshold. Default could be 1000.
  • maximum evnet age – in case there are events older than this threshold, we should remove them. Default could be 30 days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:completed Completed - but might not be released yet.
Projects
None yet
Development

No branches or pull requests

2 participants