feat: adds option to have SDE event properties on braze event root level #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @spinx and thank you very much for your contribution! |
|
Hi @adatzer .. I amended config options, on tests, they won't run on my environment (looks like due to CORS) and I'd need a lot of time to set that up as I don't have a dev env for this. Would you mind adding that ? |
|
Hey @spinx ! No problem at all! Thank you very much once again! This is a very nice feature! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our existing integration requires us to push Self Describing Events properties as root properties to Braze.
We also think this leads to much more intuitive usage with Braze and lessens the overhead when introducing new versions of events.
LMK if you'll be merging this so I finish this and add tests.