Remove deprecated $errcontext from custom error handler #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$errcontext` is an optional parameter deprecated on custom error handlers as of PHP 7.2.0 It is also unused in `Constants::warning_handler()`
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
snowplowcla
added
the
cla:no
|
I signed it!
…On Tue, Jul 2, 2019 at 8:49 AM Snowplow CLA bot ***@***.***> wrote:
Thanks for your pull request. Is this your first contribution to a
Snowplow open source project? Before we can look at your pull request,
you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn
more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80?email_source=notifications&email_token=ABXVDBXQ7XGA6BPUYP7O5JDP5N2GZA5CNFSM4H45HOUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBW5VA#issuecomment-507735764>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABXVDBTGEHVHVFYNJTR5XPLP5N2GZANCNFSM4H45HOUA>
.
|
|
Confirmed! @angsmugmug has signed the Individual Contributor License Agreement. Thanks so much |
snowplowcla
added
cla:yes
|
Thank you @angsmugmug ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$errcontextis an optional parameter deprecated on custom error handlers as of PHP 7.2.0It is also unused in
Constants::warning_handler()