Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced and Expanded Audio Support #847

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Enhanced and Expanded Audio Support #847

merged 6 commits into from
Sep 28, 2020

Conversation

stevehalliwell
Copy link
Collaborator

@stevehalliwell stevehalliwell commented Jun 28, 2020 •
edited
Loading

Description

Response to #821 and #843. Introduces additional commands for dealing with Sources and Mixers. Does not make changes the existing audio tag behaviour or Control Audio command.

What is the new behaviour?

  • FungusVariable and Property Commands for AudioClip, AudioMixer, AudioMixerGroup, AudioMixerSnapShot
  • Introduce default Mixer for Fungus, with Music, SFX, and Voice
  • New optional logic for WriterAudio to use sources from the SpeakingCharacter for sfx and voice. If none are provided defaults from the Fungus Manager are used. This new behaviour can be turned off by setting a bool on the WriterAudio if desired
  • Character Variable type and Commands introduced to allow modification of data during play, such as which audiosource to user for voice or sfx at runtime.

Pending

  • Demo scene
  • Add new types to AnyVar

Important Notes

  • My change require changes to documentation
    • Regenerate of command documentation
    • Add a wiki page explaining use of default mixer groups and changes to character speaking sources
  • My changes modify
    • the runtime execution of existing Fungus Features. e.g., Say, Menus, Portraits, etc.

@stevehalliwell
Generate Audio Var types
6961b52
@stevehalliwell
Add Audio commands and default Mixer
876b04b
@stevehalliwell
Add AudioSource Options to Characters
183afa9 
SayDialog's WriterAudio now uses the sources provided by the speaking character or the defaults from the MusicManager.
Fix // summary error in scripts
Add Character variable type and PropertyCommand
@stevehalliwell
Add new Var Types to AnyVar
e6ee328 
Fix Variable ToSummary to null check before returning data summary
@stevehalliwell stevehalliwell added Audio enhancement Adds a new feature. labels Jul 5, 2020
@stevehalliwell stevehalliwell added this to the 3.14 milestone Jul 5, 2020
This was linked to issues Jul 5, 2020
More control for playing audio #821
Closed
More control for Speaker's AudioSource and default AudioSource #843
Closed
@stevehalliwell
Add Audio Demo Scene
d531511 
Uses added audio commands and some variable data types.
Add waits on snapshottransition commands.
@stevehalliwell stevehalliwell changed the title [WIP] Enhanced and Expanded Audio Support Enhanced and Expanded Audio Support Jul 27, 2020
@stevehalliwell stevehalliwell mentioned this pull request Sep 17, 2020
Open
@stevehalliwell stevehalliwell mentioned this pull request Sep 28, 2020
Open
3 tasks
@stevehalliwell
Add AudioMixerFloat
0b7c712 
Combines Get and Set commands that existed previously, makes more sense to mirror the behaivour of Fungus Property commands
@stevehalliwell stevehalliwell merged commit 11f0b31 into develop Sep 28, 2020
@stevehalliwell stevehalliwell deleted the feature/audio branch September 28, 2020 21:25
@breadnone breadnone mentioned this pull request Dec 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Adds a new feature.
Projects
None yet
Milestone
3.14
Development

Successfully merging this pull request may close these issues.

More control for Speaker's AudioSource and default AudioSource More control for playing audio
1 participant
@stevehalliwell