Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink 9432 #2

Merged
merged 182 commits into from
May 31, 2018
Merged

Flink 9432 #2

merged 182 commits into from
May 31, 2018

Conversation

snuyanzin
Copy link
Owner

Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.

Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.

Contribution Checklist

  • Make sure that the pull request corresponds to a JIRA issue. Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

  • Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where FLINK-XXXX should be replaced by the actual issue number. Skip component if you are unsure about which is the best component.
    Typo fixes that have no associated JIRA issue should be named following this pattern: [hotfix] [docs] Fix typo in event time introduction or [hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator.

  • Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

  • Make sure that the change passes the automated tests, i.e., mvn clean verify passes. You can set up Travis CI to do that following this guide.

  • Each pull request should address only one issue, not mix up code from multiple issues.

  • Each commit in the pull request has a meaningful commit message (including the JIRA id)

  • Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

zentol and others added 30 commits May 10, 2018 08:26
…tputs

This closes apache#5836.
This closes apache#5479.
This closes apache#4893.
This closes apache#4809.
This closes apache#4621.
This closes apache#3915.
Wait for the completion of the submitted job in order to avoid that we kill
the JM while the TM tries to down load blobs from it.
…n SingleLogicalSlot

This commit properly waits for the completion of the SingleLogicalSlot's release future
until the SlotOwner has acknowledged the release. That way the ExecutionGraph will only
recover after all of its slots have been returned to the SlotPool.

As a side effect, the changes in this commit should reduce the number of redundant release
calls sent to the SlotOwner which cluttered the debug logs.

This closes apache#5980.
  - Clarify the purposes of AllocationID versus SlotRequestId.
  - Remove an unnecessary method indirection
Only happens if log level for the SlotPool is set to DEBUG
…ailed ones

In order to avoid the problem of not fulfilling allocation requests when a Mesos
tasks dies before it could register at the RM, this commit restarts all failed
Mesos tasks. The downside is that in some cases where the JM notices the failure
of a TM and would fail the job, we request tasks which are not directly needed.

This closes apache#5986.
zentol and others added 26 commits May 24, 2018 20:02
This commit replaces netty-router dependency with our own version of it, which is
simplified and adds guarantees about order of matching router patterns.

This is a prerequisite for FLINK-3952. netty-router 1.10 is incompatible with
Netty 4.1, while netty-router 2.2.0 brakes a compatibility in a way that we
were unable to use it.

This closes apache#6031.
[FLINK-7836] refactor the code and added some test code

[FLINK-7836][Client] mark field : nodeLabelExpressionMethod @nullable

This closes apache#5593.
@snuyanzin snuyanzin merged commit 3943090 into master May 31, 2018
snuyanzin added a commit that referenced this pull request Jun 22, 2018
# This is the 1st commit message:

FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than TupleTypeInfo

# This is the commit message #2:

FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than TupleTypeInfo

# This is the commit message #3:

FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than TupleTypeInfo

# This is the commit message #4:

FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than TupleTypeInfo

# This is the commit message #5:

FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than TupleTypeInfo

# This is the commit message #6:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
corrections based on comment https://issues.apache.org/jira/browse/FLINK-8255?focusedCommentId=16466381&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16466381

# This is the commit message #7:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
added expected exception type

# This is the commit message #8:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
omit issue not related changes

# This is the commit message #9:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
use instanceof as
org.apache.flink.api.java.typeutils.RowTypeInfo#isTupleType leads to
org.apache.flink.table.api.batch.ExplainTest#testJoinWithoutExtended failure

# This is the commit message #10:

Revert "FLINK-8255_Key_expressions_on_named_row_types_do_not_work"

This reverts commit 497aa20.

# This is the commit message #11:

Revert "FLINK-8255_Key_expressions_on_named_row_types_do_not_work"

This reverts commit d891cc5.

# This is the commit message #12:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
omit issue not relate changes

# This is the commit message #13:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
added expected exception to tests

# This is the commit message #14:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
added instanceof checks for DataSet

# This is the commit message #15:

FLINK-8255_Key_expressions_on_named_row_types_do_not_work
Tests corrected
snuyanzin added a commit that referenced this pull request Jun 26, 2018
# This is the 1st commit message:

Remove trailing space to make COLLECT left aligned

# The commit message #2 will be skipped:

# Added tests for element
snuyanzin pushed a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet