[FLINK-9323][build] Properly organize checkstyle-plugin configuration#5972
Closed
zentol wants to merge 2 commits intoapache:masterfrom
Closed
[FLINK-9323][build] Properly organize checkstyle-plugin configuration#5972zentol wants to merge 2 commits intoapache:masterfrom
zentol wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
+1 to the cleanup, but I think this might be breaking relative paths of the suppression files, hence causing the build to fail. Probably need to make the paths relative to "project root dir" or some "highest project dir" variable. |
Contributor
Author
|
the build failed because of a copy&paste error, flink-core and flink-optimizer are using the flink-runtime suppressions file... |
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 10, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 10, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR reorganizes the checkstyle-plugin configuration to not be duplicated in 4 modules. Instead the configuration was moved into the root pluginManagement section. The child poms were adjusted to only override settings if required.
Brief change log
Verifying this change
mvn help:effective-pomto verify that the effective poms have not changed, and that the suppression file is properly overridden