Skip to content

Conversation

@yanghua
Copy link
Contributor

@yanghua yanghua commented May 18, 2018

What is the purpose of the change

This pull request fixed the num slot config value override error.

Brief change log

  • fixed the num slot config value override error.

Verifying this change

This change is already covered by existing tests*.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@yanghua
Copy link
Contributor Author

yanghua commented May 18, 2018

cc @tillrohrmann

@yanghua
Copy link
Contributor Author

yanghua commented May 22, 2018

cc @zentol @tzulitai if you have time, please review this PR, thanks~

}

int numSlotsPerTaskManager;
if (configuration.contains(TaskManagerOptions.NUM_TASK_SLOTS)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block can be simplified to:

numSlotsPerTaskManager = configuration.getInteger(TaskManagerOptions.NUM_TASK_SLOTS, jobGraph.getMaximumParallelism());

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zentol does it need a new commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zentol

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging.

zentol pushed a commit to zentol/flink that referenced this pull request May 28, 2018
zentol pushed a commit to zentol/flink that referenced this pull request May 28, 2018
asfgit pushed a commit that referenced this pull request May 29, 2018
@asfgit asfgit closed this in 2a7c336 May 29, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants