-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-9326] TaskManagerOptions.NUM_TASK_SLOTS does not work for local/embedded mode #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| int numSlotsPerTaskManager; | ||
| if (configuration.contains(TaskManagerOptions.NUM_TASK_SLOTS)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this block can be simplified to:
numSlotsPerTaskManager = configuration.getInteger(TaskManagerOptions.NUM_TASK_SLOTS, jobGraph.getMaximumParallelism());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zentol does it need a new commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @zentol
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging.
…rk for local/embedded mode This closes apache#6041.
…rk for local/embedded mode This closes apache#6041.
…rk for local/embedded mode This closes #6041.
…rk for local/embedded mode This closes apache#6041.
What is the purpose of the change
This pull request fixed the num slot config value override error.
Brief change log
Verifying this change
This change is already covered by existing tests*.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation