Update azure-devops.ts - support local TFS (Azure devops) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agouil
reviewed
Mar 20, 2023
There was a problem hiding this comment.
The changes look good but won't work 100%. You also need to pass the user provided azureUrls all the way to https://github.com/snyk-tech-services/snyk-scm-contributors-count/blob/main/src/lib/azure-devops/azure-devops-contributors.ts#L16 from https://github.com/snyk-tech-services/snyk-scm-contributors-count/blob/main/src/cmds/azure-devops.ts#L70.
I would suggest the user defined URL to be part of the azureConnInfo object which is passed around and holds the connection context to the remote org/repositories. I think something similar to what we have for BB Server should work for Azure (https://github.com/snyk-tech-services/snyk-scm-contributors-count/blob/main/src/lib/types.ts#L40-L45).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Added support to local azure devops server
Notes for the reviewer
Instructions on how to run this locally, background context, what to review, questions…
More information
Screenshots
Visuals that may help the reviewer