Add python cli docker images #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add maven package format version fix: sanitise maven exec params
…pId and artifactId
* fix: adding the 'from' array to dependencies in maven * fix: ensure root module is in 'from' array for multi-module dependencies
Many tools treat directories named 'test' as test directories and give them special treatment. Our lib/test directory is not a test directory - it holds code for 'snyk test'. 'yarn clean' is a prime example as it removes all directories named 'test' from a project's node_modules. See: yarnpkg/yarn#2331 See: https://github.com/Snyk/snyk/issues/64
Ensures that we execute commands inside a shell and not directly. This makes it easier to run commands on windows without nasty hacks (like conditionally appending '.cmd' to the command string.. which doesn't always work). We originally used child_process.exec which actually calls child_process.spawn under the hood with the shell option set to true. Later we switched to using child_process.spawn directly without realising that the shell option for spawn defaults to false and has to be manually set. Check out the docs: https://nodejs.org/dist/latest-v6.x/docs/api/child_process.html#child_process_child_process_spawn_command_args_options
Now that we require authentication for running `snyk test`, we don't want to introduce this command to the test suite by default, as all environments will need to run `snyk auth` in order to authenticate. This also introduces extra explanation that snyk test requires auth.
Explain that some commands require authentication, and give guidance about how to authenticate.
We use a local MAC address to randomise sha1 to sign the message. In case MAC address is unreadable (CI env, for example), we defaulted to a random number, causing a crash in crypto.
Using `Math.random` is probably as random as `uuid`, but `crypto.createHash('sha1').update(mac)` requires a Buffer or a String, and not a number.
This was referenced Sep 13, 2021
This was referenced May 13, 2022
This was referenced Sep 30, 2022
This was referenced Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds docker images which install the requirements.txt file located in the current directory into a virtualenv and runs the cli commands on that virtualenv.
docker run -it -e "SNYK_TOKEN={token}" -e "MONITOR=true" -v "$PWD:/project" snyk/snyk-cli:python3 test --project-name={project_name} --org={org_id}