chore: add project and snapshot as resultmetadata #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
PeterSchafer
force-pushed
the
fix/CLI-1045_report_sarif
branch
from
971b25f to
4a9eaa0
Compare
PeterSchafer
force-pushed
the
fix/CLI-1045_report_sarif
branch
from
4a9eaa0 to
adff2a7
Compare
9 tasks
dotkas
approved these changes
Sep 17, 2025
Comment on lines
+344
to
+356
|
|
||
| if testCompleted.Results.Webui != nil { | ||
| if testCompleted.Results.Webui.Link != nil { | ||
| result.WebUiUrl = *testCompleted.Results.Webui.Link | ||
| } | ||
| if testCompleted.Results.Webui.ProjectId != nil { | ||
| result.ProjectId = testCompleted.Results.Webui.ProjectId.String() | ||
| } | ||
| if testCompleted.Results.Webui.SnapshotId != nil { | ||
| result.SnapshotId = testCompleted.Results.Webui.SnapshotId.String() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
thought: Will this go on like this into infinity? If so maybe we should consider making a more generic function at some point, if we don't want this code to be highly verbose.
There was a problem hiding this comment.
Hm, interesting thought. To be honest, I don't know if this will continue. AFAIK this metadata hasn't changed so far and it might change completely when we replace the test API with the dragonfly API.
PeterSchafer
added a commit
that referenced
this pull request
Sep 17, 2025
This was referenced Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the result metadata to keep track of the project and snapshot id.
Checklist
🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.