Skip to content

Conversation

lpinca
Copy link
Contributor

@lpinca lpinca commented Nov 10, 2021

Note: the engine.io.js file is the generated output of make engine.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

The npm run compile command does not work on macOS due to an invalid usage of sed in the postcompile.sh script

New behaviour

npm run compile runs without errors on macOS.

Other information (e.g. related issues)

First commit

build: use env in shebang

Use the `bash` executable that appears first in user's `PATH`.

Second commit

build: make postcompile.sh script work on macOS
    
On macOS the script is currently interpreted as the value of the `-i`
option. Use an empty extension for the `-i` option and the `-e` option
to specify the script.

Use the `bash` executable that appears first in user's `PATH`.
@lpinca
Copy link
Contributor Author

lpinca commented Nov 10, 2021

It looks like it does not work on Linux.

Fixed.

@lpinca lpinca force-pushed the fix/postcompile-script branch 2 times, most recently from e7667ca to 21fa6f5 Compare November 10, 2021 20:22
On macOS the script is currently interpreted as the value of the `-i`
option. Use an empty extension for the `-i` option and the `-e` option
to specify the script.
@lpinca lpinca force-pushed the fix/postcompile-script branch from 21fa6f5 to f41b8b2 Compare November 12, 2021 17:59
@darrachequesne darrachequesne merged commit 2793628 into socketio:master Nov 13, 2021
@darrachequesne
Copy link
Member

@lpinca thanks 👍

@lpinca lpinca deleted the fix/postcompile-script branch November 13, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants