Skip to content

Calls to socketsJoin() should use channelRoom() from util.js #5

@chancis

Description

@chancis

Calls to socketsJoin() when creating or joining a channel currently harcode the channel:{channel.id} string despite the fact there is a helper function in util.js for this purpose.

These calls are found in channel/create.js line 44, channel/join.js line 40, and user/reach.js line 49.

They should use the channelRoom helper function from util.js, like for example in message/send.js line 41. This will make the code easier to maintain should changes to the channel name string format ever be needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions