Skip to content

Call channelRoom() instead of hardcoding channel name string [FIX issue #5] #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Call channelRoom() instead of hardcoding channel name string [FIX issue #5] #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/channel/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ajv, logger, userRoom } from "../util.js";
import { ajv, logger, userRoom, channelRoom } from "../util.js";

const validate = ajv.compile({
type: "object",
Expand Down Expand Up @@ -41,7 +41,7 @@ export function createChannel({ io, socket, db }) {
// broadcast to other tabs of the same user
socket.to(userRoom(socket.userId)).emit("channel:created", channel);

io.in(userRoom(socket.userId)).socketsJoin(`channel:${channel.id}`);
io.in(userRoom(socket.userId)).socketsJoin(channelRoom(channel.id));

callback({
status: "OK",
Expand Down
4 changes: 2 additions & 2 deletions server/src/channel/join.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ajv, logger, userRoom } from "../util.js";
import { ajv, logger, userRoom, channelRoom } from "../util.js";

const validate = ajv.compile({
type: "object",
Expand Down Expand Up @@ -37,7 +37,7 @@ export function joinChannel({ io, socket, db }) {
// broadcast to the other tabs of the same user
socket.to(userRoom(socket.userId)).emit("channel:joined", channel);

io.in(userRoom(socket.userId)).socketsJoin(`channel:${channel.id}`);
io.in(userRoom(socket.userId)).socketsJoin(channelRoom(channel.id));

callback({
status: "OK",
Expand Down
4 changes: 2 additions & 2 deletions server/src/user/reach.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ajv, logger, userRoom } from "../util.js";
import { ajv, logger, userRoom, channelRoom } from "../util.js";

const validate = ajv.compile({
type: "object",
Expand Down Expand Up @@ -46,7 +46,7 @@ export function reachUser({ io, socket, db }) {
// broadcast to other tabs of the same user
socket.to(userRoom(socket.userId)).emit("channel:created", channel);

io.in(userRoom(socket.userId)).socketsJoin(`channel:${channel.id}`);
io.in(userRoom(socket.userId)).socketsJoin(channelRoom(channel.id));

callback({
status: "OK",
Expand Down