Skip to content

Fix compilation on GCC #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2015
Merged

Fix compilation on GCC #5

merged 2 commits into from
Apr 14, 2015

Conversation

lultimouomo
Copy link

Tested on GCC 4.9.2

lniccoli added 2 commits April 14, 2015 11:31
@lniccoli
Avoid symbol redefinition
2ff681b 
Apprently clang and msvc are fine with it, but GCC isn't.
@lniccoli
Use explicit template parametrization
2924a9f 
The arguments are of different types, so parameter deduction will not
work.
melode11 added a commit that referenced this pull request Apr 14, 2015
@melode11
Merge pull request #5 from lultimouomo/gccfix
39042f6 
Fix compilation on GCC
Patch is logically good, merge first.
@melode11 melode11 merged commit 39042f6 into socketio:master Apr 14, 2015
@lultimouomo
Copy link
Author

sio::socket::ptr will do

@lultimouomo lultimouomo deleted the gccfix branch April 14, 2015 12:32
@melode11
Copy link
Contributor

Thanks for your help

@theqf theqf mentioned this pull request Oct 18, 2018
Open
@JinChengShi JinChengShi mentioned this pull request Sep 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lultimouomo @melode11 @lniccoli