Reconnect cannot reconnect because already connected

[alexeymetelkinpro]

Getting after update to 5.0.0 (haven't upgraded a few months)

If set reconnects to "true" like this

let socket = SocketIOClient(socketURL: url,
                options: ["log": true])
            socket.reconnects = true
            socket.reconnectWait = kReconnectionTimeout

when app gets [Time out] error (for example when you put app run on pause), app trying to reconnects and calls open method of SocketEngine

public func open(opts: [String: AnyObject]? = nil) {
        connectParams = opts

        if connected {
            DefaultSocketLogger.Logger.error("Tried to open while connected", type: logType)
            client?.didError("Tried to open engine while connected")

            return
        }

        DefaultSocketLogger.Logger.log("Starting engine", type: logType)
        DefaultSocketLogger.Logger.log("Handshaking", type: logType)

        resetEngine()
        ...

and it ends up because connected is true

[alexeymetelkinpro]

forceNew = true

helps of course

[PeterL1n]

I think I experienced the similar problems. It crushes the program a lot.

[PeterL1n]

ForceNew does not help

[PeterL1n]

I downgraded to 5.3.0 and it works fine. The problem only exists in 5.3.1

It is not hard to recreate the issue at all. It is extremely common that my app crushes using slow 4G network.

You can set a button to reconnect, and press it multiple times.
Other conditions that will cause it fails include when the there is a socket request and you turn down the server in the middle, the app will crush.

5.3.1 is too unstable, I recommend taking it down

[nuclearace]

What do you mean "a button to reconnect," like a button that calls reconnect?

[nuclearace]

@alexeyhippie you can see if the latest master is any better. If it is I can push a new version. If you're using cocapods you can do pod 'Socket.IO-Client-Swift', :git => 'https://github.com/socketio/socket.io-client-swift.git'

@PeterL1n I haven't been able to reproduce your crashes. Do you have a crashlog or better yet a line number?

[alexeymetelkinpro]

Hey, @nuclearace

thanks, I tried the same with 5.3.1 - if forceNew is false then app connects well, but after first disconnect it keeps connects and disconnects right after connection established, with [Ping timeout] error. if forceNew is true - it reconnects well.

[nuclearace]

Try the latest master. I haven't released a version with the new code because I'm unsure if it's going to break things even more. It seems to work for me

[alexeymetelkinpro]

Yes, this is actually was latest master, sorry for misleading. So there is no error I got on 5.0.0, but instead it keeps connects and immediately disconnects with ping timeout error.

[alexeymetelkinpro]

In fact, git says that there is no difference in sources for

• pod 'Socket.IO-Client-Swift', '~> 5.3.1'
  and
• pod 'Socket.IO-Client-Swift', :git => 'https://github.com/socketio/socket.io-client-swift.git'

[nuclearace]

Really? Because v5.3.1...master shouldn't be on 5.3.1

[nuclearace]

Is there an easy way to reproduce this?

[nuclearace]

I went ahead and pushed a new version.