add SocketAckEmitter.expected to indicate if an ack is expected by server #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearace
requested changes
Oct 28, 2016
| @@ -44,6 +44,10 @@ public final class SocketAckEmitter : NSObject { | |||
|
|
|||
| socket.emitAck(ackNum, with: items) | |||
| } | |||
|
|
|||
| public func isRequired() -> Bool { | |||
| return ackNum != -1; | |||
There was a problem hiding this comment.
This should probably be a computed property rather than a method.
public var isRequired: Bool {
return ackNum != -1
}But to take a step back. I don't remember required acks being a thing. Were they recently added?
There was a problem hiding this comment.
in the JavaScript API, when an event expecting an ack is sent by server, the client provides the ack callback as last argument in event handler.
not a way to "require" an ack .. more like "an ack is expected"
naderio
changed the title
|
One last thing, this should opened against development rather than master. |
nuclearace
reviewed
Oct 28, 2016
| @@ -44,6 +44,10 @@ public final class SocketAckEmitter : NSObject { | |||
|
|
|||
| socket.emitAck(ackNum, with: items) | |||
| } | |||
|
|
|||
| public func isExpected() -> Bool { | |||
There was a problem hiding this comment.
Should still be a computed property.
naderio
changed the title
nuclearace
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed to send acknowledgement when required and to make NativeScript implementation mimic JavaScript's https://github.com/naderio/nativescript-socket.io/blob/64630685f2a000c79e116ed9e07662638bc32456/socket.ios.ts#L82