Useless debug key set in local storage

[rugk]

Socket.io seems to set this key, always when it is used:

debug = undefined

Socket.io v1.4.5

Discovered in Etherpad, see ether/etherpad-lite#2985 (comment)

[3rd-Eden]

https://github.com/visionmedia/debug/blob/master/browser.js#L127

Blame debug, not socket.io

[MasterJames]

Maybe it's possible to put key deletion when undefined where you need ?
if (export.storage.debug === undefined) delete export.storage.debug;
Or better skip setting if undefined? I'm not entirely sure what the problem is though.

[rugk]

The problem is just that this is a useless key and the guys from Etherpad said it was Socket.io's fault.

[rugk]

See ether/etherpad-lite#2985 (comment):

We don't reference the module "debug". It's a dependency of socket.io

So can you remove this debug module?
Why is a module called "debug" used in production versions?

[darrachequesne]

That issue was closed automatically. Please check if your issue is fixed with the latest release, and reopen if needed (with a fiddle reproducing the issue if possible).

[rugk]

Please reopen (one cannot do it by themselves when the author closes the issue) the issue as this debug module is still a dependency and you still gave no explanation for what this is used.

[darrachequesne]

Please see https://socket.io/docs/logging-and-debugging/.

If you're using webpack, you could use something like strip-loader to remove those lines from your bundle (see example)