Bump engine.io to version 2.0.2 #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the following (from engine.io changelog): * [fix] Initialize the WebSocket server in the Server constructor (socketio#476) * [chore] Bump ws to version 1.1.2 (vulnerability fix) (socketio#480)
5 tasks
2 tasks
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Includes the following (from engine.io changelog): * [fix] Initialize the WebSocket server in the Server constructor (socketio#476) * [chore] Bump ws to version 1.1.2 (vulnerability fix) (socketio#480)
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following (from engine.io changelog):
The kind of change this PR does introduce
Current behaviour
Socket.io installs version 2.0.0 of the engine.io dependency.
New behaviour
Socket.io installs version 2.0.2 of the engine.io dependency.
Other information (e.g. related issues)
IMHO it's worth considering changing this dependency to
'engine-io': '~2.0.0'to avoid having to make new releases ofsocket.ioevery timeengine.iois patched, since both modules are maintained by the same group. But I can appreciate the desire to lock things down hard.