Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec check for EOFError on disconnect #11

Merged
merged 1 commit into from Mar 3, 2019
Merged

Add spec check for EOFError on disconnect #11

merged 1 commit into from Mar 3, 2019

Conversation

jeremyjung
Copy link
Contributor

As discussed in #10 . Feedback would be appreciated.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 89

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.548%
Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 341
Relevant Lines: 394
💛 - Coveralls

ioquatix
ioquatix approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good it's almost exactly how I would have done it.

@ioquatix ioquatix merged commit a68c1e6 into socketry:master Mar 3, 2019
@davidor davidor mentioned this pull request Mar 5, 2019
Closed
@olleolleolle olleolleolle mentioned this pull request May 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremyjung @coveralls @ioquatix