Skip to content

Add redis-rb with hiredis to the perf benchmarks #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Add redis-rb with hiredis to the perf benchmarks #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a1daf
gemspec: add hiredis as a dev dependency
davidor Mar 4, 2019
a8b8295
performance_spec: add redis-rb with hiredis
davidor Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions async-redis.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,9 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "bundler"
spec.add_development_dependency "rspec", "~> 3.6"
spec.add_development_dependency "rake"

# Dependencies with C extensions
if defined?(RUBY_ENGINE) && RUBY_ENGINE == "ruby"
spec.add_development_dependency "hiredis"
end
end
15 changes: 15 additions & 0 deletions spec/async/redis/performance_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
let(:endpoint) {Async::Redis.local_endpoint}
let(:async_client) {Async::Redis::Client.new(endpoint)}
let(:redis_client) {Redis.new}
let(:redis_client_hiredis) {Redis.new(driver: :hiredis)}

it "should be fast to set keys" do
Benchmark.ips do |benchmark|
Expand Down Expand Up @@ -65,6 +66,20 @@
expect(redis_client.get(key)).to be == value
end
end

# Hiredis is C and not supported in JRuby and TruffleRuby.
if defined?(RUBY_ENGINE) && RUBY_ENGINE == "ruby"
benchmark.report("redis-rb (hiredis)") do |times|
key = keys.sample
value = times.to_s

i = 0; while i < times; i += 1
redis_client_hiredis.set(key, value)
expect(redis_client_hiredis.get(key)).to be == value
end
end
end


benchmark.compare!
end
Expand Down