-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Nathan's code. #8
Comments
Dan, it was great to meet you yesterday and I'm very excited about this merge. As I said, I seem to recall that switching to cKDTree was more of a "point of no return" in terms of making a merge difficult. It's good that that switch can make a big difference in performance, at least for some users. The actual numba components are wrapped to make them work more or less like the pure-Python versions. Please let me know if you get stuck! Thanks - nathan |
Yes, I'm glad we ran into each other, and I am sorry I had to depart early. I am collaborating with the Stebe lab and visiting every week or two -- I'll get in touch before my next trip up there and see if we can chat for awhile. |
Definitely! I'll be right downstairs from you. BTW, I really like the notebooks that are linked to in README.md now. |
Thanks. I have looked over your efforts along the same lines, and I like that we are using pandas in the same way. Are many others in your group using trackpy and your related projects? The documentation looks thorough. |
I'm glad you think so! Yes, trackpy and runtrackpy are used by a couple other people here; Python has pretty much taken over as the default environment. And pandas has changed lives here :). I don't know of anyone else using philatracks heavily except for g(r), but it is a bit more specialized. I think we agree that it's really important to make the out-of-the-box experience as fun and easy as possible for this software. I wonder if we ultimately want to make trivial datasets available as part of the tutorial. For example, a short video of flow in a microchannel with tracer particles. |
Sounds great. There is a Be advised that your branch of trackpy predates an important fix of the memory feature from awhile back. See the associated test for an explanation of what was coming out wrong. You did merge an earlier fix, also related to memory, but the second one arrived after you latest commit. |
I would be wary of loading the repo up with large binary files. It can be pretty awful on slow connections as it is. It might be worth splitting the demonstration work/template notebook off into a separate repo (trackpy-demo). |
Good catch. AFAIK no one is relying on memory support in my fork, but that's bad. I think that there is no point in backporting the fix; I should put that effort into helping complete the merge and updating runtrackpy. |
Agreed, Tom. I was thinking that the videos could be hosted on someone's group's website. But a separate repo for the movies and the tutorial notebooks could be even better. |
Sounds good. IPython-style tutorials can also be written into sphinx (a la the pandas docs) but I think self-contained tutorial notebooks might be more useful, especially if they come with videos. ReadTheDocs is up and running, btw. |
The numba-accelerated subnet linker is now merged, at nkeim/trackpy@e4e5106 . The numba subnet code passes the standard tests, and the whole thing also works in an environment without numba installed. Note that as with KDTree, numba is not the default strategy in this version. Before I make a pull request, I'd still like to try it on some real data, and get some sense of the performance improvement. |
Nathan, is there anything else from your codebase or runtrackpy that belongs in trackpy proper? If not, we'll close this. |
Nothing else to add! As far as superseding Thanks!! |
It works on |
FYI, @nkeim , Tom Caswell is over my shoulder, and we're serious about merging trackpy in the next few weeks. We're going to reconcile my (Dan's) branch first and then yours. I'm also going to pull in all my feature-finding, tests, and analysis code. See related issues.
"Easy"
link_strategy
.neighbor_strategy
.Hard
The text was updated successfully, but these errors were encountered: